fix: add section as a prop of ad composer

newsuk · Jul 4, 2017 · 431d9a1 · 431d9a1
1 parent 71af2ae
commit 431d9a1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/gpt/__tests__/ad-composer.test.js b/packages/gpt/__tests__/ad-composer.test.js
@@ -15,7 +15,7 @@ describe("AdComposer test", () => {
   it("renders a snapshot with one Ad", () => {
     const tree = renderer
       .create(
-        <AdComposer>
+        <AdComposer section="article">
           <Ad code="ad-header" />
         </AdComposer>
       )
@@ -27,7 +27,7 @@ describe("AdComposer test", () => {
   it("renders a snapshot with more than one Ad", () => {
     const tree = renderer
       .create(
-        <AdComposer>
+        <AdComposer section="article">
           <Ad code="ad-header" />
           <Ad code="intervention" />
         </AdComposer>

diff --git a/packages/gpt/ad-composer.js b/packages/gpt/ad-composer.js
@@ -1,4 +1,5 @@
 import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Broadcast } from "react-broadcast";
 
 import AdManager from "./ad-manager";
@@ -15,7 +16,7 @@ class AdComposer extends Component {
     this.adManager = new AdManager({
       networkId: "25436805",
       adUnit: "d.thetimes.co.uk",
-      section: "article",
+      section: props.section,
       gptManager,
       pbjsManager,
       getSlotConfig
@@ -39,4 +40,8 @@ class AdComposer extends Component {
   }
 }
 
+AdComposer.propTypes = {
+  section: PropTypes.string.isRequired
+};
+
 export default AdComposer;
diff --git a/packages/gpt/gpt.stories.js b/packages/gpt/gpt.stories.js
@@ -15,7 +15,7 @@ storiesOf("GPT", module).add("render two ads in article page", () => {
       >
         Render ads
       </a>
-      <AdComposer>
+      <AdComposer section="article">
         <Ad code="ad-header" />
         <Ad code="intervention" />
       </AdComposer>