Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Banner #3904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ export const BannerStory = ({ group }) => (

<Story name="Banner">
{BannerStory.bind({})}
</Story>
</Story>
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import {
BannerWrapper,
BannerContentWrapper
} from './styles';
import { CloseIconBlack, EmailIcon } from '../../../assets';
import CloseIconBlack from './assets/CloseIconBlack';
import EmailIcon from './assets/EmailIcon';

type Props = {
onClose: () => void;
Expand Down
1 change: 1 addition & 0 deletions packages/ts-components/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,4 @@ export {
default as safeDecodeURIComponent
} from './utils/safeDecodeURIComponent';
export { ArticleSidebar } from './components/article-sidebar/ArticleSidebar';
export { Banner } from './components/banner/banner';
Original file line number Diff line number Diff line change
Expand Up @@ -15,40 +15,6 @@ exports[`Icons Component: BreadcrumbIcon BreadcrumbIcon renders with default pro
</DocumentFragment>
`;

exports[`Icons Component: CloseIconBlack CloseIconBlack renders with default props 1`] = `
<DocumentFragment>
<svg
fill="none"
height="24"
viewBox="0 0 14 14"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M14 1.41L12.59 0L7 5.59L1.41 0L0 1.41L5.59 7L0 12.59L1.41 14L7 8.41L12.59 14L14 12.59L8.41 7L14 1.41Z"
fill="#000"
/>
</svg>
</DocumentFragment>
`;

exports[`Icons Component: EmailIcon EmailIcon renders with default props 1`] = `
<DocumentFragment>
<svg
fill="none"
height="24"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M22 9.98V19C22 20.1 21.1 21 20 21H4C2.9 21 2 20.1 2 19L2.01 7C2.01 5.9 2.9 5 4 5H14.1C14.04 5.32 14 5.66 14 6C14 6.34 14.04 6.68 14.1 7H4L12 12L15.67 9.71C16.14 10.14 16.69 10.47 17.3 10.69L12 14L4 9V19H20V10.9C20.74 10.75 21.42 10.42 22 9.98ZM16 6C16 7.66 17.34 9 19 9C20.66 9 22 7.66 22 6C22 4.34 20.66 3 19 3C17.34 3 16 4.34 16 6Z"
fill="#000"
/>
</svg>
</DocumentFragment>
`;

exports[`Icons Component: FilledArrowIcon FilledArrowIcon renders with default props 1`] = `
<DocumentFragment>
<svg
Expand Down
2 changes: 0 additions & 2 deletions packages/ts-newskit/src/assets/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export { default as TooltipIcon } from '../assets/TooltipIcon';
export { default as CloseIconBlack } from '../assets/CloseIconBlack';
export { default as EmailIcon } from '../assets/EmailIcon';
export { default as FilledArrowIcon } from './FilledArrowIcon';
export { default as BreadcrumbIcon } from './BreadcrumbIcon';
1 change: 0 additions & 1 deletion packages/ts-newskit/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ export { JobTitle } from './components/misc/job-title/job-title';
export {
UpdateButtonWithDelay
} from './components/misc/update-button/update-button-with-delay';
export { Banner } from './components/misc/banner/banner';

// TODO Remove after tests - borisovy
8 changes: 6 additions & 2 deletions packages/ts-newskit/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@

"lib": ["es6", "dom", "es2019"],
"types": ["jest"],
"typeRoots": ["node_modules/@types", "src/types", "../../node_modules/@types"]
"typeRoots": [
"node_modules/@types",
"src/types",
"../../node_modules/@types"
]
},
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["node_modules/**"],
"compileOnSave": false
}
}