Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TMC-133): Affiliate link detection and wrapping #3987

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

feat(TMC-133): Affiliate link detection and wrapping #3987

wants to merge 58 commits into from

Conversation

simun-ivanac
Copy link

@simun-ivanac simun-ivanac commented Nov 19, 2024 •
edited by jira bot
Loading

Description

Add detection for affiliate links in articles, and wrap them (skimlinks, trackonomics) if needed.

TMC-133
TMC-132

Checklist

  • Have you done any manual testing?
  • Does it have automated tests?
  • Do you need any other PRs merged before this (if so please list)?
  • Do you need to update the README/Runbook
  • Have you checked for accessibility?

Screenshots (if appropriate):

Include screenshots if needed.

@simun-ivanac simun-ivanac self-assigned this Nov 19, 2024
@simun-ivanac simun-ivanac requested a review from a team as a code owner November 19, 2024 14:36
@lukakereceni lukakereceni force-pushed the feat/TMC-133-affiliate-link-detection-and-wrapping branch from 99cd87c to 0027742 Compare January 8, 2025 20:07
@lukakereceni lukakereceni force-pushed the feat/TMC-133-affiliate-link-detection-and-wrapping branch from 06e67ae to 1ab5d16 Compare January 9, 2025 14:16
simun-ivanac and others added 29 commits January 20, 2025 12:58
@simun-ivanac @lukakereceni
add affiliate wrapping
0ea3913
@simun-ivanac @lukakereceni
update tests
20e2213
@simun-ivanac @lukakereceni
update code formatting
c51c028
@simun-ivanac @lukakereceni
update snapshots
303be3c
@lukakereceni
Add Trackonomics regex
817e504
@lukakereceni
Hardcoded contentPageUrl
5f2790f
@lukakereceni
Update snapshots
f9fd8d2
@lukakereceni
Add console logs
7cfc0eb
@lukakereceni
Add new test attribute
8bc253b
@lukakereceni
Add new test attribute
97e12e2
@lukakereceni
Fix lint issue
32538e5
@lukakereceni
Remove ssrAttr
7fe3ee2
@lukakereceni
Added addAttribute func
5b23b00
@lukakereceni
Added paywall-ssr
33e7b07
@lukakereceni
Test article content
948312d
@lukakereceni
Keep the first two items
298b73a
@lukakereceni
Added affiliate links validation logic
cb4711c
@lukakereceni
Added formattedArticle
5fdc7ba
@lukakereceni
Added articleContent
150c799
@lukakereceni
Fix some logic issues
b338af6
@lukakereceni
Remove affiliate validation from Article Skeleton component
2333f4e
@lukakereceni
Remove setExternalLinkTargets
8a3ce57
@lukakereceni
Add contentPageUrl
e2fe1b6
@lukakereceni
Implement fetch function
a39eff4
@lukakereceni
Implement fetchSkimlinksDomains func
849ea1f
@lukakereceni
Destructure domains from data obj
86ed8f6
@lukakereceni
Implement logic for Skimlinks wrapping
7f9eecd
@lukakereceni
Remove affiliate-validation from ArticleSkeleton
29f290c
@lukakereceni
Merge branch 'feat/TMC-133-affiliate-link-detection-and-wrapping' of h…
b9b35e3 
…ttps://github.com/newsuk/times-components into feat/TMC-133-affiliate-link-detection-and-wrapping
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukakereceni lukakereceni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simun-ivanac @lukakereceni