fix: UniqueKey does not work for controller tag when building app on release mode in Flutter 3.22 #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the
PodPlayerController
usesUniqueKey().toString()
to generate a tag for the internalPodGetXController
. However, in Flutter 3.22, there is an issue thatUniqueKey
always returns "Instance of UniqueKey" in release mode. No matter how manyPodPlayerController
are created, they still share the samePodGetXController
instance.To address this issue, I've replaced the usage of
UniqueKey
withUuid
for tag generation in thePodPlayerController
class.Uuid
is a safer and more standard approach for generating unique identifiers, and it ensures that eachPodPlayerController
instance will have a unique tag.This change affects the
_init
method in thePodPlayerController
class, where thegetTag
variable is assigned. I've tested the changes and confirmed that eachPodPlayerController
instance now receives a uniquePodGetXVideoController
instance as expected.