Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional parameters to server#console #48

Merged
merged 1 commit into from
Aug 29, 2013

Conversation

rubemz
Copy link
Contributor

@rubemz rubemz commented Aug 28, 2013

No description provided.

@@ -165,11 +165,11 @@ def vnc(vid)
end

# Retrieves server console information.
def console(vid)
perform_request(action: 'vserver-console', vserverid: vid)
def console(vid, access = nil, time = nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the method signature: console(vid, params ={})?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boone
Copy link
Contributor

boone commented Aug 28, 2013

👍

@jmazzi
Copy link
Collaborator

jmazzi commented Aug 29, 2013

@rubemz looks good, can you squash it?

@rubemz
Copy link
Contributor Author

rubemz commented Aug 29, 2013

squashed 👍

On Thu, Aug 29, 2013 at 11:15 AM, Justin Mazzi notifications@github.comwrote:

@rubemz https://github.com/rubemz looks good, can you squash it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/48#issuecomment-23492379
.

Rubem Nakamura

jmazzi added a commit that referenced this pull request Aug 29, 2013
add optional parameters to server#console
@jmazzi jmazzi merged commit 145e6f5 into master Aug 29, 2013
@jmazzi jmazzi deleted the feature/console-parameters branch August 29, 2013 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants