The famous <ul id="admin_messages">MESSAGE HERE</ul> #940

elfeffe · 2015-09-11T11:04:46Z

I have Magento 1.9.1 and Turpentine 0.6.5, with Ultimo Theme.

And I have the same issue as some people had #112 #153. But that issues are from 2013, I don't believe they are not fixed yet.

When I post a review I get

<ul id="admin_messages">MESSAGE HERE</ul>

Is there any way to fix this?
I don't have that error if I disable Turpentine.

My turpentine_esi.xml looks like

 <reference name="global_messages">
            <action method="setEsiOptions">
                <params>
                <method>esi</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                </params>
            </action>
        </reference>
    <reference name="messages">
            <action method="setEsiOptions">
                <params>
                <method>esi</method>
                <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                </params>
            </action>
        </reference>

Any help will be really appretiated, I'm getting crazy with this.

miguelbalparda · 2015-09-11T12:48:33Z

I think the fix for this issue is in the devel branch. How did you get Turpentine? Can you please download the devel branch and see if the error persists?

elfeffe · 2015-09-11T14:09:59Z

Nope, I will explain. Ihave installed it using git, I have switched to devel branch now and.

with this

        <reference name="global_messages">
            <action method="setEsiOptions">
                <params>
                    <method>ajax</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                    <only_cache_if>empty</only_cache_if>
                </params>
            </action>
        </reference>
        <reference name="messages">
            <action method="setEsiOptions">
                <params>
                    <method>ajax</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                    <only_cache_if>empty</only_cache_if>
                </params>
            </action>
        </reference>

And this

The block refreshes with ajax and creates this code

<div class="col-main">
                        <!-- AJAX START [global_messages] -->
<div id="turpentine-esi-block-adcb2807a97f6084b951516cc1890a79b7339481fbdcdf10f65fafb6767fce9a"><ul id="admin_messages">Tu opinión ha sido aceptada y enviada para su revisión.</ul></div><!-- AJAX END [global_messages] -->
                        <div id="newsletterajax"></div>


<script type="text/javascript">
    var optionsPrice = new Product.OptionsPrice([]);
</script>
<div id="messages_product_view"><!-- AJAX START [messages] -->
<div id="turpentine-esi-block-59d82f41339ead2a8c2f6d7c21156b41f23f11c47d56b0013c11ff11bd74dd61"></div><!-- AJAX END [messages] -->
</div>

The HTML is wrong the generated message is

<ul id="admin_messages">Tu opinión ha sido aceptada y enviada para su revisión.</ul>

If I leave the ESI xml using Ajax method, but I switch "Enable AJAX Flash Messages" to Disable

The generated html is

<ul class="messages"><li class="success-msg"><ul><li><span>Tu opinión ha sido aceptada y enviada para su revisión.</span></li></ul></li></ul>

Its ok, but the content is cached and there is no way to refresh it, everytime I visit the product, I get the message

If I switch method to ESI instead of AJAX, and I leave "Enable AJAX Flash Messages" as DISABLED, generated html is correct

<ul class="messages"><li class="success-msg"><ul><li><span>Tu opinión ha sido aceptada y enviada para su revisión.</span></li></ul></li></ul>

But, again, I see the message everytime. It never refreshes
I tried changing to

    <reference name="global_messages">
            <action method="setEsiOptions">
                <params>
                    <method>esi</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                    <only_cache_if>no_text</only_cache_if>
                </params>
            </action>
        </reference>
        <reference name="messages">
            <action method="setEsiOptions">
                <params>
                    <method>esi</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                    </flush_events>
                    <only_cache_if>no_text</only_cache_if>
                </params>
            </action>
        </reference>

Note the change in "only_cache_if" section
But nothing, it never refreshes.
I also tried applying

<ttl>0</ttl>

But the cache never refreshes

It only refreshes cache if you set method to AJAX and Enable AJAX Flash Messages, but it returns incorrect HTMl as in master branch.

elfeffe · 2015-09-11T14:15:04Z

One more
When I enable "Enable AJAX Flash Messages"
It makes 2 AJAX request, I think this is wrong too

http://turp.mystore.com/turpentine/esi/getBlock/method/ajax/access/private/ttl/0/hmac/136908b62efd256395b258e47b8f2318d50e93667f06c16cf77ec140cdb604e9/data/OruN-OAv5qzlHicSQy6ePG7mXTcckjJ0bGyvvwyaHMoTl4S..EEwWXPZN8c9WXkyS8QDD-NEPzFc6HlUF4X93m9ysn1ee127EV5onMJnIkMZXiBW58tfIIybuWJ1TNHAptCjKRM.pZUtrYAR6fISqwZKM7aRMNpPpgScuwsaG7f3VE1A8RG9JGJEpHLorfBtSDNPD-CJ.WPY0FX.4FbFocOLdxzxzSZuYGdGpuUFT8sb3SRpkrJiAgYz-itTnKhEB5FRsb2nmxZnvXxuqRc8bTJ1LLtSdo2TfwORgRWMZ5Qv0XR0AEJQw7ya60Lep.K0XOQNnZFFLx.BKBqvk8eXgFK9vLLUcCHNjZljwZbEFdatEAi3.kLwn92pwt1KFqTJ/

and

http://turp.mystore.com/turpentine/esi/getBlock/method/ajax/access/private/ttl/0/hmac/521e143667c0fa6a536386043060c38da947d3e8db1251470b5d5317db028ede/data/YGwxWb0J0Zi3siC8PKWLBo9HboyjNqqnW.JBg96le2lGVe0EkwizPth8wjDon-f04r.wTcrlqCcdL5IycAkkl9wLzElEEWdSfmPBp1EK5Pz3EiEXsYHwuTng64TSIBMo9W.Op55gJqy4WVutlMG1-Uaq4DLTyRawmaAEAs1KCyWySATAXGN85z.K15zd5N9aCzO9dSEQsrkdsd9rbV71x7mHimhW-mVQe3A2DIDklI5SpRHb86LAEtq0CoDnkLcIiHUf2M50Pigi8unltrqQzmb9Jk.AKk4cPfoVUXehxjMEseZ5wBp3sObPezSQy2Eztu9gzWBA2SGiouzUVxGHBp.PfDU5tzG3a9fqKGqJg5PJ9DdD2HbbKw==/

I think only one is needed

elfeffe · 2015-09-12T12:44:52Z

I discovered how it works.
What " Enable AJAX Flash Messages" really means is "Use Nexcessnet_Turpentine_Block_Core_Messages class or not", it runs even if the block is AJAX or ESI.

 <ul id="admin_messages">MESSAGE HERE</ul>

And also cache the result
Is there any fix for this?

elfeffe · 2015-09-15T07:00:13Z

@miguelbalparda sorry Miguel, just to know. Is there any fix or any plan to fix it?
The extension can't be used with this bug, am I the only one with this problem?

miguelbalparda · 2015-09-15T11:20:28Z

We work hard to fix all the issues. It seems to be you are the only one experiencing this issue for now, so I wouldn’t say the extension can't be used.

elfeffe · 2015-09-15T11:23:25Z

Ok, I only want to know if it's only me the one with the problem.

elvinristi · 2015-09-16T15:26:37Z

Nope, you aren't the only one. getting same. In my case I have multiple texts there and they are in content following each other without html-tags.

aricwatson · 2015-10-22T19:17:21Z

Try adding another flush event to clear the cache when new products are added:

<reference name="global_messages">
            <action method="setEsiOptions">
                <params>
                    <method>esi</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                        <controller_action_predispatch_checkout_cart_add />
                    </flush_events>
                    <only_cache_if>no_text</only_cache_if>
                </params>
            </action>
        </reference>
        <reference name="messages">
            <action method="setEsiOptions">
                <params>
                    <method>esi</method>
                    <access>private</access>
                    <flush_events>
                        <core_session_abstract_add_message/>
                        <controller_action_predispatch_checkout_cart_add />
                    </flush_events>
                    <only_cache_if>no_text</only_cache_if>
                </params>
            </action>
        </reference>

Additionally, do you know steps to replicate this on default install/theme?

elvinristi · 2015-10-22T19:26:14Z

Actually this is core bug

--- app/code/core/Mage/Core/Block/Messages-o.php    2015-10-13 20:35:25.000000000 +0000
+++ app/code/core/Mage/Core/Block/Messages.php  2015-10-13 20:40:49.000000000 +0000
@@ -213,7 +213,7 @@
         $html = '<' . $this->_messagesFirstLevelTagName . ' id="admin_messages">';
         foreach ($this->getMessages($type) as $message) {
             $html.= '<' . $this->_messagesSecondLevelTagName . ' class="'.$message->getType().'-msg">'
-                . ($this->_escapeMessageFlag) ? $this->escapeHtml($message->getText()) : $message->getText()
+                . ($this->_escapeMessageFlag ? $this->escapeHtml($message->getText()) : $message->getText())
                 . '</' . $this->_messagesSecondLevelTagName . '>';
         }
         $html .= '</' . $this->_messagesFirstLevelTagName . '>';

Question might be why Turpentine uses "admin_messages" container and when Turpentine is off then this is not being used.

tdgroot · 2016-01-15T10:56:15Z

Having the same issues..
The messages get added, but they're cached. And nothing seems to flush the block.

The following I tried:

Flush events
Setting TTL to 1
The core bug fix
Probably not gonna work because esi_options are only used on Mage_Core_Block_Template descendants..

<reference name="global_messages">
    <action method="setEsiOptions">
        <params>
            <access>private</access>
            <ttl>1</ttl>
            <method>esi</method>
            <scope>page</scope>
            <flush_events>
                <controller_action_predispatch/>
            </flush_events>
        </params>
    </action>
</reference>

<reference name="messages">
    <action method="setEsiOptions">
        <params>
            <access>private</access>
            <ttl>1</ttl>
            <method>esi</method>
            <scope>page</scope>
            <flush_events>
                <controller_action_predispatch/>
            </flush_events>
        </params>
    </action>
</reference>

@elfeffe Did you manage to fix it?

addison74 · 2016-01-15T23:04:18Z

@elfeffe: You are not alone. I got this issue on "Orders and Returns" page too. The error message when you fill in wrong the form doesn't have the correct Magento css style. I checked the source code and there is a different ul tag used which creates trouble, the one you mentioned in your first post. Please see the images bellow, first the visual style of the tag and how is source code of the page.

This is a VM without Varnish/Turpentine installed:

This is a VM with Varnish/Turpentine installed:

tdgroot · 2016-01-19T14:05:05Z

I got my messages working! This is what I did.

From the docs I quote:

Only blocks that inherit from the Mage_Core_Block_Template class may have caching policies.

Since neither the block Mage_Core_Block_Messages or Nexcessnet_Turpentine_Block_Core_Messages inherit from Mage_Core_Block_Template, no caching policies exist/work for the blocks.

But, we want to define caching policies though. We want it to be dynamic, so we need some wrapper around it. The solution:

In my local.xml

<default>
    <reference name="root">
        <action method="unsetChild">
            <name>global_messages</name>
        </action>
        <action method="unsetChild">
            <name>messages</name>
        </action>
        <block type="core/template" name="message_wrapper" as="message_wrapper" template="custom/message-wrapper.phtml">
            <action method="setEsiOptions">
                <params>
                    <access>private</access>
                    <scope>page</scope>
                    <ttl>0</ttl>
                </params>
            </action>
            <block type="core/messages" name="global_messages" as="global_messages"/>
            <block type="core/messages" name="messages" as="messages"/>
        </block>
    </reference>
</default>

And in my custom/message-wrapper.phtml

<div class="messages-wrapper">
    <?php
        echo $this->getChildHtml('global_messages');
        echo $this->getChildHtml('messages');
    ?>
</div>

addison74 · 2016-01-31T22:18:11Z

@Desmaster your solution is not working for me. I placed local.xml in my theme layout folder, then custom/message-wrapper.phtml in template. I flushed the cache, restarted varnish, none worked.

Could you please give more details about file locations and changes?

tdgroot · 2016-02-01T06:54:59Z

Make sure you output the defined block in the root templates(page/1column.phtml etc) like this: echo $this->getChildHtml('messages_wrapper') and get rid of the messages output that's in the root templates already.

addison74 · 2016-02-01T14:26:30Z

@Desmaster. I followed all your steps and I could not fix it.

I created inside /app/design/frontend/default/mytheme/layout/local.xml with your suggested content.
I created inside /app/design/frontend/default/mytheme/template/custom/message-wrapper.phtml with your suggested content.
I edited /app/design/frontend/default/mytheme/template/page/1 column.phtml as follows:

<div class="col-xs-12">
    <div class="main">
    <?php echo $this->getChildHtml('breadcrumbs') ?>
        <div class="col-main">
            <div class="padding-s">
            <?php echo $this->getChildHtml('global_messages') ?>
            <?php echo $this->getChildHtml('content') ?>
            </div>
        </div>
    </div>
</div>

In line 51 getChildHtml('global_messages') ?> I replaced global_messages with message_wrapper. I flushed the cache and restarted Varnish but there is no positive result, same behavior. To find out if this is the right template file I commented the whole line 51 and the message is not appearing, so this was the right template for editing.

I am getting this issue in "Orders and Returns" page here is a screenshot:

addison74 · 2016-02-01T17:30:19Z

@elvin-vaimo was right. I've made that change in Magento core files and here is the result:

Even it is an error message its class it is "admin_messages" instead of "messages". See how the containers are bonded together. Do a test with login form. You will get this html tag for an error:

<ul class="messages">
    <li class="error-msg">
        <ul><li><span>Invalid login or password.</span></li></ul>
    </li>
</ul>

I would like to know as @elvin-vaimo " why Turpentine uses "admin_messages" container and when Turpentine is off then this is not being used".

elfeffe · 2016-02-05T16:08:23Z

@miguelbalparda Sorry to bother you Miguel, but you can see I'm not the onlyone with this problem

npearson72 · 2016-06-28T15:03:46Z

+1

Also having this issue

aricwatson · 2016-07-14T21:25:53Z

I'd like to take a look at this. Can anyone give me steps to replicate on a default store? I'd like to rule out that it's theme-specific.

addison74 · 2016-07-15T07:39:09Z

Check my posts.

geminpak · 2016-08-09T19:04:25Z

@addison74 Hello, was wondering what changes you made to Magento's core files in order to correctly display the error messages? I am currently looking at Messages.php in the core files.

addison74 · 2016-09-08T16:55:51Z

Check this one: #940 (comment). It is like taking an ax and killing a pig.

For the moment it is some kind a bandage. It is not a proper solution, a more elegant one should come from Turpentine module.

yoosefi · 2017-11-15T01:19:41Z

We had the same problem and saw that messages were being stashed in core/session instead of customer/session. Putting them in customer/session resolved the issue for us.

Hope that helps anyone.

treestonemedia · 2018-03-15T20:14:26Z

+1
Also having this issue

norgeindian · 2018-08-28T11:52:40Z

We face the same issue when a customer subscribes for the newsletter in our footer.

The message is not displayed like a usual magento success message, but as an admin_message.
During our debugging we ended up at Nexcessnet_Turpentine_Block_Core_Messages::_real_toHtml()
This function is called in Nexcessnet_Turpentine_Block_Core_Messages::_toHtml() and decides, if the function getHtml or getGroupedHtml shall be called, depending on the name in layout.

And here is the thing, we do not really understand. Disabling turpentine one can see, that usually Mage_Core_Block_Messages::_toHtml() always calls getGroupedHtml().

Does anyone have an idea, why this decision is implemented the way it is?

elvinristi · 2018-08-28T12:01:39Z

@norgeindian , see #940 (comment) to fix the core bug there on M1.

norgeindian · 2018-08-28T12:04:20Z

@elvinristi , thanks for the hint, but did not work for me. Faced the same issue.
And the question remains, why turpentine calls this function, if the usual way would be getGroupedHtml()

miguelbalparda · 2018-08-29T17:48:22Z

Am not really sure why this was coded like this, what would be a better way to do it?

norgeindian · 2018-08-31T07:43:43Z

@aheadley , as far as I can see it was you who wrote most of the code in these functions. Could you explain the reasons for that?
In my local tests everything works fine, when _real_toHtml just calls getGroupedHtml in every case, but maybe there are issues I don't see right now.

miguelbalparda · 2018-09-12T09:16:25Z

There is a proposed fix for this in #1508, care to check and report back?

norgeindian · 2018-09-17T07:35:33Z

If you could include this fix, this would be great and in my eyes we could then close this issue.

fixed admin_messages in frontend, fixes #940

miguelbalparda added unconfirmed-bug support labels Sep 11, 2015

sprankhub mentioned this issue Sep 11, 2018

fixed admin_messages in frontend, fixes #940 #1508

Merged

miguelbalparda added a commit that referenced this issue Sep 26, 2018

Merge pull request #1508 from sprankhub/patch-2

9900bf3

fixed admin_messages in frontend, fixes #940

miguelbalparda closed this as completed in a9ec7b5 Nov 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The famous <ul id="admin_messages">MESSAGE HERE</ul> #940

The famous <ul id="admin_messages">MESSAGE HERE</ul> #940

elfeffe commented Sep 11, 2015

miguelbalparda commented Sep 11, 2015

elfeffe commented Sep 11, 2015

elfeffe commented Sep 11, 2015

elfeffe commented Sep 12, 2015

elfeffe commented Sep 15, 2015

miguelbalparda commented Sep 15, 2015

elfeffe commented Sep 15, 2015

elvinristi commented Sep 16, 2015

aricwatson commented Oct 22, 2015

elvinristi commented Oct 22, 2015

tdgroot commented Jan 15, 2016

addison74 commented Jan 15, 2016

tdgroot commented Jan 19, 2016

addison74 commented Jan 31, 2016

tdgroot commented Feb 1, 2016

addison74 commented Feb 1, 2016

addison74 commented Feb 1, 2016

elfeffe commented Feb 5, 2016

npearson72 commented Jun 28, 2016

aricwatson commented Jul 14, 2016

addison74 commented Jul 15, 2016

geminpak commented Aug 9, 2016

addison74 commented Sep 8, 2016 •

edited

Loading

yoosefi commented Nov 15, 2017 •

edited

Loading

treestonemedia commented Mar 15, 2018

norgeindian commented Aug 28, 2018

elvinristi commented Aug 28, 2018

norgeindian commented Aug 28, 2018

miguelbalparda commented Aug 29, 2018

norgeindian commented Aug 31, 2018

miguelbalparda commented Sep 12, 2018

norgeindian commented Sep 17, 2018

The famous <ul id="admin_messages">MESSAGE HERE</ul> #940

The famous <ul id="admin_messages">MESSAGE HERE</ul> #940

Comments

elfeffe commented Sep 11, 2015

miguelbalparda commented Sep 11, 2015

elfeffe commented Sep 11, 2015

elfeffe commented Sep 11, 2015

elfeffe commented Sep 12, 2015

elfeffe commented Sep 15, 2015

miguelbalparda commented Sep 15, 2015

elfeffe commented Sep 15, 2015

elvinristi commented Sep 16, 2015

aricwatson commented Oct 22, 2015

elvinristi commented Oct 22, 2015

tdgroot commented Jan 15, 2016

addison74 commented Jan 15, 2016

tdgroot commented Jan 19, 2016

addison74 commented Jan 31, 2016

tdgroot commented Feb 1, 2016

addison74 commented Feb 1, 2016

addison74 commented Feb 1, 2016

elfeffe commented Feb 5, 2016

npearson72 commented Jun 28, 2016

aricwatson commented Jul 14, 2016

addison74 commented Jul 15, 2016

geminpak commented Aug 9, 2016

addison74 commented Sep 8, 2016 • edited Loading

yoosefi commented Nov 15, 2017 • edited Loading

treestonemedia commented Mar 15, 2018

norgeindian commented Aug 28, 2018

elvinristi commented Aug 28, 2018

norgeindian commented Aug 28, 2018

miguelbalparda commented Aug 29, 2018

norgeindian commented Aug 31, 2018

miguelbalparda commented Sep 12, 2018

norgeindian commented Sep 17, 2018

addison74 commented Sep 8, 2016 •

edited

Loading

yoosefi commented Nov 15, 2017 •

edited

Loading