Skip to content

Commit

Permalink
Rename TODOs in file
Browse files Browse the repository at this point in the history
  • Loading branch information
gondiaz committed Feb 27, 2021
1 parent 17f234e commit 2fd07ec
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions invisible_cities/detsim/buffer_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ def bin_sensors(sensors : pd.DataFrame,
return bins[:-1], bin_sensors


## !! to-do: clarify for non-pmt versions of next
## !! to-do: Check on integral instead of only threshold?
# TODO: clarify for non-pmt versions of next
# TODO: Check on integral instead of only threshold?
def find_signal_start(wfs : Union[pd.Series, np.ndarray],
bin_threshold: float ,
stand_off : int ) -> List[int]:
Expand All @@ -56,9 +56,9 @@ def find_signal_start(wfs : Union[pd.Series, np.ndarray],
indices = indices_and_wf_above_threshold(eng_sum,
bin_threshold).indices
if len(indices) == 0: return []
## Just using this and the stand_off for now
## taking first above sum threshold.
## !! To-do: make more robust with min int? or similar
# Just using this and the stand_off for now
# taking first above sum threshold.
# TODO: make more robust with min int? or similar
all_indx = split_in_peaks(indices, stand_off)
return [pulse[0] for pulse in all_indx]

Expand Down

0 comments on commit 2fd07ec

Please sign in to comment.