Skip to content

Commit

Permalink
922 Bump actions/checkout version in GHA workflows
Browse files Browse the repository at this point in the history
#922

[author: gonzaponte]

The current version issues the following warning:

```
The following actions uses node12 which is deprecated and will be
forced to run on node16: actions/checkout@v2.
For more info:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
```

Bumping to the latest version seems to get rid of it.

[reviewer: jwaiton]

Good change, we move from node16 to node20 with checkout@v4. From
reading https://github.com/actions/checkout/releases changelogs from
v2 -> v3 -> v4, it seems like there are no backwards compatibility
issues and the tests execute as expected.

There may be more complex behaviour in the differences between node16
& 20 but I can't find anything significant in documentation that warns
of this, or complaints online of said incompatibilities between
versions. Again, the tests run as expected looking at the output so
I'm happy.
  • Loading branch information
jwaiton authored and carhc committed Nov 13, 2024
2 parents 7777d82 + 49a06d1 commit 378b642
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check_db_calibration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
python-version: [3.8]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- id: files
uses: jitterbit/get-changed-files@v1
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ${{ matrix.platform }}

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get LFS files
run: git lfs pull
# - name: Fix Conda permissions on macOS
Expand Down

0 comments on commit 378b642

Please sign in to comment.