Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event_range = 0 doesn't work #573

Closed
gonzaponte opened this issue Oct 28, 2018 · 3 comments · Fixed by #854
Closed

event_range = 0 doesn't work #573

gonzaponte opened this issue Oct 28, 2018 · 3 comments · Fixed by #854
Labels

Comments

@gonzaponte
Copy link
Collaborator

I was trying to run diomira with event_range = 0 for a test and it crashes.

  • Is this behaviour expected?
  • Should it be fixed?
@jjgomezcadenas
Copy link
Collaborator

Diomira is not supposed to run with event_rang=0, but probably we want to add a protection so that it insults nicely the user (something like: you moron, want me to run with no events? ) and exit, rather than crashing. Same for other cities.

@gonzaponte
Copy link
Collaborator Author

Well, it is not completely clear to me whether we should allow it or not. From my experience, I think it could be a way of testing the cities "initialization process", that is, everything before dataflow.push. In particular, I've found this situation while trying to add a test for #570. I wanted to run diomira with no events so it doesn't draw random numbers, but it does run the part of the code were the seed is established.

@jjgomezcadenas
Copy link
Collaborator

Sounds to me as too technical. Normal user should not run diomira with event_range=0, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants