Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diomira random seed #570

Merged
merged 2 commits into from
Oct 28, 2018

Conversation

gonzaponte
Copy link
Collaborator

Allow the fixing of the random seed in Diomira.
Add a test to ensure this feature is not removed without notice.

@gonzaponte gonzaponte force-pushed the fix-diomira-random-seed branch 2 times, most recently from d0e5bc3 to 8a91538 Compare October 27, 2018 17:28
Copy link
Collaborator

@jjgomezcadenas jjgomezcadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed and straight forward

@gonzaponte gonzaponte force-pushed the fix-diomira-random-seed branch from 8a91538 to b4f4e3c Compare October 28, 2018 10:18
@gonzaponte gonzaponte merged commit b4f4e3c into next-exp:master Oct 28, 2018
gonzaponte added a commit that referenced this pull request Oct 28, 2018
#570

[author: gonzaponte]

Allow the fixing of the random seed in `Diomira`.
Add a test to ensure this feature is not removed without notice.

[reviewer: jjgomezcadenas]

Needed and straight forward
@gonzaponte gonzaponte deleted the fix-diomira-random-seed branch October 28, 2018 12:15
@gonzaponte gonzaponte mentioned this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants