Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flex100 to the list of available detectors #729

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

jmunozv
Copy link
Collaborator

@jmunozv jmunozv commented Jul 3, 2020

Flex100 corresponds to the theoretical NextFlex detector configured to emulate the actual Next100 detector.
This MR adds Flex100 to the list of detectors that can be analyzed with IC.

@jmunozv jmunozv requested a review from jmbenlloch July 3, 2020 15:08
@jmbenlloch
Copy link
Contributor

Everything looks good but you forgot to commit the file invisible_cities/database/localdb.Flex100DB.sqlite3 itself. That copy of the database commited too. It has to be uploaded via LFS so everyone can get that file when checking out this branch or cloning the repo.

@jmunozv
Copy link
Collaborator Author

jmunozv commented Jul 4, 2020

Everything looks good but you forgot to commit the file invisible_cities/database/localdb.Flex100DB.sqlite3 itself. That copy of the database commited too. It has to be uploaded via LFS so everyone can get that file when checking out this branch or cloning the repo.

Done.

Copy link
Contributor

@jmbenlloch jmbenlloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes the necessary changes to add a new detector: Flex100.

@carmenromo carmenromo merged commit d0bcbf1 into next-exp:master Jul 7, 2020
@jmunozv jmunozv deleted the Flex100 branch July 7, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants