Detsim signal simulation module. #734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new version is the signal simulation module for detsim loop-based implementation
|
Added new signal simulation module for the loop-based implementation of detsim. |
Merged
carmenromo
pushed a commit
that referenced
this pull request
Feb 22, 2021
#757 [author: gondiaz] This PR contains the detsim functions that simulate the S1 signal from the total number of photons using the S1 LightTable. It is a single module `simulate_S1.py` and its corresponding test module. Also, the S1 LightTable test file is added. This PR, along with PR #756, overrides PRs #698, #699 and #734. [reviewer: mmkekic] This PR adds functionalities for simulation of the S1 scintillation light needed for detsim city. The code is clear and tested, good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #691:
This module contains the functions that compute the photoelectrons at each sensor using the LightTables and PSF. Also, the functions that generate the S1 times distribution.