Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection for empty waveforms #776

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Add protection for empty waveforms #776

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2923a59
Add a test that demonstrates an unwanted behaviour
gondiaz Feb 26, 2021
4636371
Return empty list if no signal is found
gondiaz Feb 26, 2021
ade421f
Add filter for events with no signal
gondiaz Feb 26, 2021
4b5c93b
Rewrite detsim pipe with signal filter implementation
gondiaz Feb 26, 2021
1af6f61
Add empty waveforms test assertions
gondiaz Feb 26, 2021
5cfe87c
Rewrite buffy pipe with signal filter implementation
gondiaz Feb 26, 2021
7ca39e9
Cosmetics
gondiaz Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions invisible_cities/detsim/buffer_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def find_signal_start(wfs : Union[pd.Series, np.ndarray],
eng_sum = wfs.sum()
indices = indices_and_wf_above_threshold(eng_sum,
bin_threshold).indices
if len(indices) == 0: return []
## Just using this and the stand_off for now
## taking first above sum threshold.
## !! To-do: make more robust with min int? or similar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really not worth opening a separate PR for it, so, while we're touching this file, could you please add a single commit which fixes all the to-dos in this file (and any others that you are already touching in this PR), changing them to this precise spelling: TODO (exactly four characters, all uppercase, no spaces, no dashes). This is because many development tools recognize TODO and can help managing them.

Expand Down