Add maximum charge variable #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing for reasons which I don't recognize as being the typical spurious ones. In fact, it looks rather likely that this PR has broken some existing tests. |
|
Please rebase on top of #783 as soon as it is merged, so that we get clearer test reporting on GHAs. |
|
#783 has been merged. Please rebase. |
gondiaz
force-pushed
the
dst_qmax
branch
2 times, most recently
from
54ebed3 to
7cd34ab
Compare
jerenner
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds maximum charge (qmax) variable in DST tables, therefore it modifies both dorothea and penthesilea files.