Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make paolina faster #809

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Make paolina faster #809

merged 1 commit into from
Dec 10, 2021

Conversation

gondiaz
Copy link
Collaborator

@gondiaz gondiaz commented Dec 1, 2021

This PR makes Paolina a bit faster by avoiding duplicated function calls.
I naively estimated a 10-20% improvement.

@gondiaz gondiaz requested a review from paolafer December 1, 2021 19:49
@gondiaz gondiaz added the easy label Dec 10, 2021
paolafer
paolafer approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@paolafer paolafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is straightforward and makes the code more efficient. Approved!

@MiryamMV MiryamMV merged commit 7e5016d into next-exp:master Dec 10, 2021
@gondiaz gondiaz deleted the paolina branch December 10, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolafer paolafer paolafer approved these changes

Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gondiaz @paolafer @MiryamMV