Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update event ID #820

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Update event ID #820

merged 2 commits into from
Jul 12, 2022

Conversation

paolafer
Copy link
Collaborator

@paolafer paolafer commented Jun 3, 2022

This PR changes the event_ID field of the IC table from int32 to int64 to avoid overflow in the case of large background productions.

@paolafer paolafer force-pushed the update-event-id branch 3 times, most recently from 85f7af8 to 1f8cc76 Compare June 6, 2022 07:03
gonzaponte
gonzaponte approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. The test files have been updated according to the change in the persistent data format allowing to remove the ad-hoc type conversions in the test suite.

Great job.

@paolafer
Copy link
Collaborator Author

The correspondent nexus PR has been approved and merged. Can one of the designated mergers merge this one, please?

@MiryamMV MiryamMV merged commit 666647c into next-exp:master Jul 12, 2022
@paolafer paolafer deleted the update-event-id branch February 23, 2023 08:45
@paolafer paolafer mentioned this pull request Jun 27, 2024
Merged
jwaiton pushed a commit that referenced this pull request Jul 26, 2024
@gonzaponte @jwaiton
884 Change the last remaining event types to int64
6dadcff 
#884

[author: paolafer]

This PR changes the last items of int32 types assigned to the event
ID. Since PR #820, all event IDs should be int64, to deal with large
background productions. These items probably escaped our attention at
the time of that PR.

[reviewer: gonzaponte]

Good job!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzaponte gonzaponte gonzaponte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolafer @gonzaponte @MiryamMV