Filter nexus delayed hits in detsim #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiryamMV
reviewed
Sep 16, 2022
S1 simulation was performed by sampling the s1-times distribution, but if the S1 total pes is large the sampling might produce a memory overflow. In this commit the simulation is changed from sampling to computing the S1 distribution in the waveform by using the distribution pdf.
This is a muon-induced xenon activation. The muon induces the recoil of 137Xe which generates a very low energy hit. The 137Xe atom decays much later producing the regular hits. The energy of the recoil hit has been artificially reduced in order to have a more stable test. The idea here is to have an event that "always" produces 0 electrons.
These events consist of a very low-energy hit (in this case produced by the recoil of 137Xe) followed by very delayed regular hits. When these hits are filtered out due to their high delay, only the low-energy hit remains, which sometimes does not produce electrons, leading to a crash.
Events that do not produce any photons are discarded
|
This addition to the code fixes the error raised occasionally in low energy events. Thanks @gonzaponte!! |
|
My addition filters out events that do not produce any photons, which generated an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detsimcontains a parametermax_timesuch that all hits ocurring afterwards this threshold are not included in the waveform simulation. For example, a nucleus can decay to its ground state via two gamma deexcitations, being the decay halt-life of the latter much larger than the initial.In such a case, if the second decay is within the limit set by
max_time,detsimwill be able to process both signals and split them in two different events if the second decay occurs at time larger than thebuffer_lengthof the waveform.But if the second decay time is larger than
max_time,detsimis not filtering these hits and an error is raised in the waveform creation.This PR solves this issue by adding a function that filters the hits at times larger than
max_time. A warning is raised for these events for the user to be aware that the simulation might not provide the expected output.This PR also fixes the fact that S1 has to be computed using the hits at the active and buffer volumes, not only in the active as was previously done.