Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename argument to avoid confussion #827

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Rename argument to avoid confussion #827

merged 2 commits into from
Nov 21, 2022

Conversation

gonzaponte
Copy link
Collaborator

The first argument to the gauss function was named amp which might mislead the reader to believe that it's the function amplitude at x=mu. It has been renamed to area

carmenromo
carmenromo approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@carmenromo carmenromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaussian function argument has been renamed to avoid misleading. Approved!

@MiryamMV MiryamMV merged commit 8be75c6 into next-exp:master Nov 21, 2022
@gonzaponte gonzaponte deleted the rename-arg branch December 1, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmenromo carmenromo carmenromo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gonzaponte @carmenromo @MiryamMV