Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NEXT100 PMT mapping according to latest changes at LSC #849

Merged
merged 1 commit into from
May 8, 2024

Conversation

jmbenlloch
Copy link
Contributor

This PR updates NEXT100's database to fix the PMT channel mapping according to the latest data from the installation at LSC.

@gonzaponte
Copy link
Collaborator

Does this supersede #845?

@jmbenlloch
Copy link
Contributor Author

Yes, the mapping included in #845 is not valid anymore. This PR adds the current version.

@gonzaponte
Copy link
Collaborator

Is this just checked by human inspection (if so who can do it?) or do we have any tools to check the validity of the new mapping?

@paolafer
Copy link
Collaborator

Shouldn't we merge this asap?

@jmbenlloch
Copy link
Contributor Author

There has been another update on the PMT channel mapping. The latest commit includes this new version.

We have no tool to check the validity of the mapping. In this case the latest PMT mapping included in the DB corresponds with the one provided by the electronic engineers in this document. The table is on page "EP Mapping - FINAL", the lower left table with headers "Sensor ID" and "ElecID".

@paolafer
Copy link
Collaborator

paolafer commented May 7, 2024

Ok, now I think we need to approve and merge it soon, since we're going to start taking data anytime.

Copy link
Collaborator

@paolafer paolafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@carhc carhc merged commit d351f46 into next-exp:master May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants