Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix to be able to create the current environment on MacOS 13.3.1 #856

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

paolafer
Copy link
Collaborator

I had problems creating the 3.8-2022-04-13 environment and this fix by Corey Adams solves it.

@paolafer paolafer requested a review from gonzaponte February 16, 2024 15:13
@gonzaponte
Copy link
Collaborator

I am not convinced this won't have (undesired) side effects in other systems. The GHA passed, so I guess it doesn't, but I don't trust it either. I have to dwell on it.

@gonzaponte
Copy link
Collaborator

After dealing with this myself, I realized that we must also change the architecture depending on the system. Right now it's hardcoded to x86_64, but we need arm64, especially for the new Macs with an M1 chip. It will be painful to test this properly.

Copy link
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is ok and does not disrupt the installation process in other machines.

@jwaiton jwaiton merged commit e59a9c0 into next-exp:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants