Add protection for no input files #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good PR that passes all tests and works as intended :) One oddity I noticed is that if you provide two input files, one non-existent and one good, it will not throw up any complaints about the first (or second, ordering doesnt matter) missing file. Should this be filed under a new/separate issue? |
|
Good catch. No, it should at least let you know. I will add a test and fix it. |
Now if any pattern fails, we raise a FileNotFoundError earlier in the process, instead of checking if all of them failed at the end.
gonzaponte
force-pushed
the
protect-no-input-files
branch
from
882ee2d to
5fc13d1
Compare
jwaiton
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a protection against not specifying
files_in. However, if we do set this variable, but it does not correspond to a valid file or files through globbing, the city will silently finish causing confusion. This PR fixes that.