-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kr evolution functions #894
base: master
Are you sure you want to change the base?
Conversation
The sigmoid function maybe should be in the module with other functions, or import from scipy. |
gaus_sig_function Not clear what are x and y, and how yoy compute the seed. Please add comments |
resolution add comments that you return the relative resolution and error |
get_number_of_time_bins this seems to me overcoding, when this function, if only used one in the code, can be resumed in just one line of code easy to read! |
get_time_series_df the comment is not clear, you say that you devide the event but in reality you divide the dst in masks with consecutive time intervals. Please clarify the comment on the definition of the function. |
In compute_drift_v, please x-check is there is still no access to the DB! |
e0_xy_correction function, if you use only one time or in one place, this function is maybe over-coding, as it is just very fre lines, but anyhow, it is acceptable. |
In * computing_kr_parameters* as we discussed this morning, there is no need for the norm_strat and norm_value arguments. |
cut_effs_evolution as we discussed in the meeting, it should a function, than from the dst and a list of masks returns a list of efficiencies. The computing_kr_parameter functions should call this function to obtain the S1, S2 and Band efficiencies and then store then in the dst and not update them. |
The internal function add_krevol should take as arguments, if any, kdst, map, and masks (a list of masks). Then the function should:
The comments of what does this function are not right. Please indicate that the function, applies the mask to the dst, split the dst in time intervals, and for each one computes a set of variables, for example life-time, drift-velocity, S1, S2 averaget, etc and returns them in a DataFrame. |
This reverts commit ddefe930c9d4e3d8994c83a5cee4a565ccf19e09.
This PR provides the functions for the parameter evolution calculation. It should be the last one of the related PR (#872, #876...) to be approved since it sits on top of them. Test Suit will fail at the beggining. Function tests to be commited in the following days.