Improve utilities for structure comparison in tests #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
force-pushed
the
improve-table-cmp
branch
from
d612fa9 to
48fc387
Compare
|
The code is self explanatory, adds beneficial structure to the comparison of two tables, and runs with no issues. There seems to be no testing of the conditions in which the function |
gonzaponte
force-pushed
the
improve-table-cmp
branch
from
48fc387 to
ce6efce
Compare
|
Added 3 tests. |
jwaiton
reviewed
Oct 21, 2024
jwaiton
approved these changes
Oct 22, 2024
gonzaponte
force-pushed
the
improve-table-cmp
branch
from
033b591 to
09bde4a
Compare
jwaiton
force-pushed
the
improve-table-cmp
branch
from
09bde4a to
ebb06d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a table or a dataframe comparion fails in a test, we don't get much information. This PR adds a bit of information to the failure to help identify their causes.
This branch is currently on top of #895, the corresponding commits will be removed before merging.
Closes #840