Skip to content

Commit

Permalink
Merge pull request #250 from paolafer/fix-latest-tag
Browse files Browse the repository at this point in the history
Fix latest tag
  • Loading branch information
paolafer authored Mar 8, 2024
2 parents 505e73c + 788736f commit ba4eacf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 3 additions & 2 deletions SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,10 @@ if not env['LIBPATH']:
if env['QT_DIR'] == NULL_PATH:
try:
env['QT_DIR'] = os.environ['QT_DIR']
env.Append(CPPPATH = [env['QT_DIR']+'/include'])
except KeyError:
Abort('QT installation directory could not be found.')
env.Append(CPPPATH = [env['QT_DIR']+'/include'])
print('Env variable for QT installation directory could not be found.'
'The compilation usually succeeds anyway, except for some MacOS versions.')

## ##################################################################

Expand Down
8 changes: 6 additions & 2 deletions source/materials/OpticalMaterialProperties.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1642,9 +1642,11 @@ namespace opticalprops {
// Visible spectrum taken from: E. Hecht, Optics, 5th edn., Pg 142, Fig 4.69
std::vector<G4double> reflectivities = { 0.90, 0.90, 0.70, 0.60, 0.40, 0.35, 0.30, 0.20, 0.20};

// We assume that the reflectivity is mostly specular.
// Measurements may be required to update these values
// Add Properties
mpt->AddProperty("SPECULARLOBECONSTANT", {optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("SPECULARSPIKECONSTANT",{optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("SPECULARSPIKECONSTANT",{optPhotMinE_, optPhotMaxE_}, {0.75, 0.75});
mpt->AddProperty("BACKSCATTERCONSTANT", {optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("REFLECTIVITY", refl_energies, reflectivities);
return mpt;
Expand All @@ -1665,9 +1667,11 @@ namespace opticalprops {
// Visible spectrum taken from: https://doi.org/10.1063/1.331503
std::vector<G4double> reflectivities = { 0.60, 0.60, 0.50, 0.40, 0.20, 0.20};

// We assume that the reflectivity is mostly specular.
// Measurements may be required to update these values
// Add properties
mpt->AddProperty("SPECULARLOBECONSTANT", {optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("SPECULARSPIKECONSTANT",{optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("SPECULARSPIKECONSTANT",{optPhotMinE_, optPhotMaxE_}, {0.75, 0.75});
mpt->AddProperty("BACKSCATTERCONSTANT", {optPhotMinE_, optPhotMaxE_}, {0., 0.});
mpt->AddProperty("REFLECTIVITY", refl_energies, reflectivities);
return mpt;
Expand Down

0 comments on commit ba4eacf

Please sign in to comment.