Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prblackbox #114

Merged
merged 58 commits into from
Sep 16, 2022
Merged

Prblackbox #114

merged 58 commits into from
Sep 16, 2022

Conversation

MiryamMV
Copy link
Contributor

@MiryamMV MiryamMV commented Jun 3, 2021

More recent and improved (hopefully cleaner) version of the BlackBox geometry. It includes the options for SiPM boards with no mask, mask with circular holes and mask for rectangular holes.

jmalbos
jmalbos reviewed Jun 8, 2021
View reviewed changes
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBoxSiPMBoard.cc Outdated Show resolved Hide resolved
@paolafer
Copy link
Contributor

What is the status of this PR @MiryamMV, @jmalbos?

@MiryamMV MiryamMV force-pushed the PRblackbox branch 3 times, most recently from efbaedf to 944d52e Compare January 13, 2022 10:41
@paolafer
Copy link
Contributor

paolafer commented Jun 1, 2022 •
edited
Loading

Some tests are failing, can you have a look at this?

paolafer
paolafer reviewed Jul 11, 2022
View reviewed changes
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
macros/test.init.mac Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/SiPMSensl.cc Outdated Show resolved Hide resolved
source/generators/LED450LWcone.cc Outdated Show resolved Hide resolved
source/generators/LED450LW.cc Outdated Show resolved Hide resolved
source/generators/LED450LWcone.cc Outdated Show resolved Hide resolved
paolafer
paolafer reviewed Jul 20, 2022
View reviewed changes
test.config.mac Outdated Show resolved Hide resolved
paolafer
paolafer requested changes Sep 12, 2022
View reviewed changes
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Outdated Show resolved Hide resolved
source/geometries/BlackBox.cc Show resolved Hide resolved
macros/black_box.config.mac Outdated Show resolved Hide resolved
@paolafer
Copy link
Contributor

paolafer commented Sep 13, 2022 •
edited
Loading

Review the full geometry, including the SiPM board, and set to false the overlap checking. We want to remove as much verbosity as possible in the output.

paolafer
paolafer approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@paolafer paolafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds the geometry of the set-up used in the black box to study the response of a board of SiPMs. It also adds a generic Lambertian generator, which can be used for other purposes. Very good job!

@paolafer paolafer merged commit c7ed5ad into next-exp:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmalbos jmalbos jmalbos left review comments

@paolafer paolafer paolafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiryamMV @paolafer @jmalbos