Move function definitions where the smart pointer is complete #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the move assignment operator is used, the smart pointer needs to be complete, which is not the case in DetectorConstruction.h, where we use forward declaration.
|
This PR is becoming urgent, can the designated reviewers (@jmalbos and @gondiaz) deal with it before the end of the week? Otherwise I would ask @gonzaponte to step in if he's available. |
|
I wont be able to make it soon...
…On Wed, Jun 15, 2022, 08:27 Paola Ferrario ***@***.***> wrote:
This PR is becoming urgent, can the designated reviewers ***@***.***
<https://github.com/jmalbos> and @gondiaz <https://github.com/gondiaz>)
deal with it before the end of the week? Otherwise I would ask @gonzaponte
<https://github.com/gonzaponte> to step in if he's available.
—
Reply to this email directly, view it on GitHub
<#164 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISTSDG235HXL674ZD4JZ53VPHK3VANCNFSM5UOKRY7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'll do it by Friday. |
jmalbos
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that a compilation error is prompted when nexus is used as a third party library by an external software. The reason of the error is that we use a forward declaration of the smart pointer in
DetectorConstruction.hand we use the move assignment operator in an inline function in the same header file. However, when the move assignment operator is used, the smart pointer needs to be complete, which is not the case in DetectorConstruction.h, because of forward declaration.Therefore, this PR moves the definitions of the functions to the
.ccfile.