Change type of event ID to int64 to avoid overflow #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalbos
reviewed
Jun 1, 2022
paolafer
force-pushed
the
change-id-type
branch
2 times, most recently
from
9e341da to
e5de0e2
Compare
We don't use unsigned int64, because in IC we use PyTables, which does not allow indexing with that type, for the moment.
|
@jmalbos, are you happy with this PR? If so, please, approve it! |
jmalbos
approved these changes
Jul 12, 2022
paolafer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type of the event ID in all the h5 tables, to avoid problems of overflow during big productions such as the background model.