Add Polished Aluminium material #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soleti
reviewed
Feb 17, 2023
soleti
reviewed
Feb 17, 2023
Move some code lines for better readability
|
I suggest that you write the references directly in the code, as done with other materials. This way, it is easier to retrieve them, when needed. Nevermind, I found it :-). |
paolafer
reviewed
Feb 24, 2023
| { | ||
| G4MaterialPropertiesTable* mpt = new G4MaterialPropertiesTable(); | ||
|
|
||
| // REFLECTIVITY |
There was a problem hiding this comment.
I would remove these commented lines.
paolafer
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
A new material with its optical properties has been added. The code is well structured and documented, compiles and runs, therefore I approve it! Good job on your first contribution, @mariandbt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Polished Aluminum material to Optical Material Properties because, by placing an Aluminum disk at one end of the fibers, the number of photons collected by the sensor at the other end is higher. This way there's no need to work with 2 photosensors, one at each end of the fibers.
The values for the reflectance are taken from:
Polished Aluminum Reflectance vs Wavelength plot
DOI:10.4236/ampc.2015.511046
The values for the refractive index are taken from:
Polished Aluminum Refractive Index vs Energy plot