Remove superfluous examples of macros #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolafer
force-pushed
the
remove-superfluous-examples
branch
from
6040d55 to
0a05410
Compare
halmamol
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
I agree that these 2 set of macros are not necessary considering the existance of other SingleParticle generator examples (like the mentioned NEXT100.Neutron, or the NEW_geantino pair of macros). I've crosschecked, they are also not referenced on the Wiki so after beign removed we don't need to edit it. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two sets of macros, which are considered obsolete now. They are simple examples of the usage of
SingleParticleGenerator, which is illustrated in a variety of other examples already. TheNEXT100.Neutronpair of macros is retained to show an example of neutron generation and several examples of muon generation are already there.Therefore, I prefer to remove these extra examples to speed up the test execution and to keep the examples to a limited number for clarity.