Modify code and tests to avoid creating output files when tests run #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaiton
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Approved
All tests pass. I receive some warnings related to deprecated functions which we've assumed are due to python package differences. These don't appear to be a cause for concern.
Output from tests contained within tmp/ directory on my computer, which is regularly wiped. So works as expected 👍
OS: Ubuntu 22.04.3 LTS x86_64
Kernel: 6.2.0-34-generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies tests and a few classes to prevent tests from creating permanent files.
Now said files (hdf5 and csv) are created in a temporary directory, which is deleted at the end of the test run.