Adjust/update Next100 geometry #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altering ICS length to match reality, and changing position of feedthrough and calibration ports to match expected locations from drawings. Updated optical geometry to account for previous changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next100OpticalGeometry.ccto match the more up to date distances between the sapphire windows, the EL gate, and the tracking plane that were introduced toNext100.ccin this PR but were not carried over.On my machine both
pytestand the Catch2 tests passed (with the pytest containing warnings that appeared unrelated to this change).General summary of geometry changes can be seen here.
geometry_changes.pdf