Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sipm_pos from if-loop. #233

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

MiryamMV
Copy link
Contributor

This PR defines sipm_pos outside the verbosity_ if-loop. This corrects all the overlaps in this volume encountered when running the overlap checks.

@paolafer paolafer self-requested a review January 23, 2024 14:56
Copy link
Contributor

@paolafer paolafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlap is fixed, I approve it!

@paolafer paolafer merged commit a39b715 into next-exp:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants