Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users of deprecated classes #255

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Warn users of deprecated classes #255

merged 3 commits into from
Apr 24, 2024

Conversation

gonzaponte
Copy link
Contributor

  • ELLookupTable
  • RadiusDependentDriftField
  • WavelengthShifting

@gonzaponte
Warn users of deprecated classes
e5fc9aa 
- ELLookupTable
- RadiusDependentDriftField
- WavelengthShifting
@paolafer
Copy link
Contributor

paolafer commented Apr 23, 2024 •
edited
Loading

I'm thinking that we should also remove the addition of the WavelengthShifting process from NexusPhysics, so there's no doubt that we are not using it anymore. Can you do that?

@gonzaponte
Copy link
Contributor Author

Yes. Why is it that we don't see this process even though it is added to the list?

@paolafer
Copy link
Contributor

paolafer commented Apr 23, 2024 •
edited
Loading

Because our custom-made process uses properties with different names than those defined in the TPB material. Right now there are no optical material properties with the appropriate parameters, so that process never gets to do anything.

paolafer
paolafer approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@paolafer paolafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR clarifies which classes are not being used in nexus, to avoid confusion for users.

@paolafer paolafer merged commit d08e319 into next-exp:master Apr 24, 2024
1 check passed
@gonzaponte gonzaponte deleted the deprecated branch April 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolafer paolafer paolafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzaponte @paolafer