Lab generator #69
Lab generator #69
Conversation
| auto sampler = nexus::CylinderPointSampler2020(minRad, maxRad, halfLen, | ||
| 0., CLHEP::twopi, | ||
| rotation, origin); | ||
| auto point = G4ThreeVector(minRad * G4UniformRand(), |
There was a problem hiding this comment.
If this point is meant to be inside the cylinder, shouldn't the displacement and rotation also be taken into account? And the z coordinate be related to halfLen?
| auto sampler = nexus::BoxPointSampler(inner_dim, inner_dim, inner_dim, thickness, | ||
| origin, rotation); | ||
|
|
||
| auto point = G4ThreeVector(inner_dim * G4UniformRand(), |
There was a problem hiding this comment.
Same comment as with the CylinderPointSampler2020.
|
As a general comment, I find the procedure of projection quite complicated to follow. I would add some more explicit documentation in the |
andLaing
force-pushed
the
lab-generator
branch
from
e5967ae to
94b59ac
Compare
|
Think that makes things a bit more consistent and adds to the explanation. I've rebased on the recent merges to master too so that the tests are ran on the PR. |
Adds to NEW and Next100 for the EXTERNAL generator of the lead shielding
Points generated on disc then ray projected to the requested region.
There was a problem hiding this comment.
This branch has been validated with a dedicated muon simulation. The proper angular distribution of the muons is kept. It enhances the efficiency of the simulation: the fraction of simulated muons inducing interactions in the active volume is increased by a factor ~100
|
I'm closing this PR, because it is superseded by #228. |
Improves the way muons are generated using the angular correlations expected in a lab.
Introduces
ProjectToRegionmethods in the geometries (NEW, NEXT100 and NEXT100Shielding and LSCHallA for now) andGetIntersectto theBoxPointSamplerandCylinderPointSampler2020.Tests added to nexus-test
Replaces #54 which was closed in the transition to a public repository.