[로또 미션] 박성빈 미션 제출합니다. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choi-JJunho
reviewed
Jul 11, 2024
Comment on lines
+31
to
+35
| private static void validateDivideZero(final int money) { | ||
| if (money % LOTTO_COST != 0) { | ||
| throw new IllegalArgumentException("돈은 " + LOTTO_COST + "의 배수여야 함"); | ||
| } | ||
| } |
| public class Lotto { | ||
| private final Set<LottoNumber> numbers; | ||
|
|
||
| public Lotto(final Set<LottoNumber> numbers) { |
There was a problem hiding this comment.
파라미터에 final이 있는게 있고 없는게 있는데 본인만의 기준이 있는건가요?
There was a problem hiding this comment.
열심히 생각하면서 쓰다가 힘들어서 포기했습니다 ㅎㅋㅋㅎㅋ
Comment on lines
3
to
4
| import static lotto.global.Constants.MAX_NUMBER; | ||
| import static lotto.global.Constants.MIN_NUMBER; |
There was a problem hiding this comment.
해당 값을 전역적인 변수로 두면 어떤 최소/최대_숫자 인지 헷갈리지 않을까 고민이 되네요
제 개인적으로는 LottoNumber의 속성값인 듯 하여 LottoNumber 클래스 내부에 해당 상수를 정의하지 않을까 싶은데 어떻게 생각하세요?
There was a problem hiding this comment.
LottoNumber 클래스의 내부에 두는게 더 나을 것 같네용
Comment on lines
10
to
11
| private List<Lotto> lottos; | ||
| private List<Lotto> customLottos; |
There was a problem hiding this comment.
customLottos의 size를 이용하여 수동으로 몇장 구매했는지 출력하기위해 구분했습니다.
지금 생각해보면 구분할 필요가 없는거 같아요
| package lotto.model; | ||
|
|
||
| public class Money { | ||
| private final int money; |
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class NumberGenerator implements Generator { |
There was a problem hiding this comment.
차라리 LottoNuberGenerator로 구체화를 시켜버리는건 어떤가요?
start, end, size를 파라미터로 받아서 Set을 만들어주는 객체는 역할이 다소 모호해보인다는 개인적인 의견입니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
으악 머리아파요...
첫 단추가 매우매우 중요하단걸 깨달았습니다...
3단게부터 급하게 짜느라 요구사항을 하나도 못지킨거 같아요
연산자 오버로딩이 안되는게 너무 불편했어요
리뷰 잘 부탁드립니다