Step1: EntityLoader 구현 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghojeong
commented
Jul 8, 2023
Comment on lines
+31
to
+44
| public T mapRow(ResultSet resultSet) { | ||
| try { | ||
| final T object = clazz.getDeclaredConstructor().newInstance(); | ||
| final ResultSetMetaData metaData = resultSet.getMetaData(); | ||
| final int columnCount = metaData.getColumnCount(); | ||
| for (int i = 1; i <= columnCount; i++) { | ||
| fieldsByName.get( | ||
| metaData.getColumnLabel(i) | ||
| ).set( | ||
| object, | ||
| resultSet.getObject(metaData.getColumnName(i)) | ||
| ); | ||
| } | ||
| return object; |
There was a problem hiding this comment.
ResultSetMetaData 위주로 EntityLoader 를 구현해보았습니다.
liquidjoo
approved these changes
Jul 11, 2023
Comment on lines
+11
to
15
| if (entityManager.isNew(entity)) { | ||
| entityManager.persist(entity); | ||
| } else if (entityManager.isDirty(entity)) { | ||
| entityManager.merge(entity); | ||
| } |
There was a problem hiding this comment.
else-if 를 사용하지 않고 구현할 수 있을 것 같은데요~
도전해보아도 좋을 것 같습니다 :)
Comment on lines
+20
to
+27
| this.fieldsByName = ColumnFields.forQuery(clazz) | ||
| .stream().collect(Collectors.toMap( | ||
| ColumnName::build, | ||
| field -> { | ||
| field.setAccessible(true); | ||
| return field; | ||
| } | ||
| )); |
Comment on lines
+31
to
+44
| public T mapRow(ResultSet resultSet) { | ||
| try { | ||
| final T object = clazz.getDeclaredConstructor().newInstance(); | ||
| final ResultSetMetaData metaData = resultSet.getMetaData(); | ||
| final int columnCount = metaData.getColumnCount(); | ||
| for (int i = 1; i <= columnCount; i++) { | ||
| fieldsByName.get( | ||
| metaData.getColumnLabel(i) | ||
| ).set( | ||
| object, | ||
| resultSet.getObject(metaData.getColumnName(i)) | ||
| ); | ||
| } | ||
| return object; |
Comment on lines
+33
to
+35
| final String query = isNew(entity) | ||
| ? dml.getInsertQuery(entity) | ||
| : dml.getUpdateQuery(entity); |
There was a problem hiding this comment.
삼항 연산자도 좋으나 코드의 가시성을 위해 분리해보아도 좋을 것 같습니다
ghojeong
added a commit
to ghojeong/jpa-association
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
예비군 훈련을 다녀오느라 PR 이 늦었습니다.
ResultSetMetaData 를 활용해 EntityLoader 를 구현해보았습니다.
지난 미션에서 마지막에 주셨던 피드백을 아직 제대로 반영하지 못했지만,
우선 구현한데까지라도 이렇게 PR 을 올립니다.