Step1 #981
Merged
Step1 #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malibinYun
approved these changes
Nov 22, 2023
Comment on lines
+2
to
+3
|
|
||
| class StringAddCalculator { |
There was a problem hiding this comment.
객체 안에 가변으로 관리되는 멤버변수가 없으니, object 키워드를 활용해보셔도 좋겠어요 :)
object StringAddCalculator {
...
Comment on lines
+9
to
+10
|
|
||
| val customDelimiterRegex = Regex("//(.)\n(.*)").find(text) |
There was a problem hiding this comment.
Regex 객체는 생성 비용이 많이 드니, 한 번만 만들어두고 재활용해보는 건 어떨까요?
Comment on lines
+16
to
+17
|
|
||
| private fun parseTokens(text: String, customDelimiter: String): List<Int> { |
There was a problem hiding this comment.
토큰들을 파싱하는 것은 다른 객체로 분리해봐도 좋겠네요!
Comment on lines
+18
to
+19
| require(text.contains("-").not()) { "음수를 입력할 수 없습니다." } | ||
| require(text.contains(Regex("[,:${customDelimiter}]"))) { "숫자와 지정된 구분자만 입력할 수 있습니다." } |
There was a problem hiding this comment.
어떤 값이 들어와서 exception이 발생했는지 에러 메시지에 담아 표시해주는 건 어떨까요?
Comment on lines
+14
to
+19
| private lateinit var calculator: StringAddCalculator | ||
|
|
||
| @BeforeEach | ||
| fun setUp() { | ||
| calculator = StringAddCalculator(); | ||
| } |
There was a problem hiding this comment.
StringAddCalculator는 불변객체여서, 매 테스트마다 생성하지 않고, 필드에 한 개만 생성해도 괜찮아 보이네요! :)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
다른 개인적인 일이 많아서, 늦게 미션을 시작했습니다.
잘부탁드립니다!
bottom-up 방식으로 작성해보려고 노력했습니다.