Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendors Problem with New 8.9.0 Custom CDN Feature #434

Closed
3 tasks done
tyadan opened this issue Jan 5, 2022 · 2 comments · Fixed by #428 or #439
Closed
3 tasks done

Vendors Problem with New 8.9.0 Custom CDN Feature #434

tyadan opened this issue Jan 5, 2022 · 2 comments · Fixed by #428 or #439
Labels
Bug Something isn't working Solved
Milestone

Comments

@tyadan
Copy link

tyadan commented Jan 5, 2022


Expected behavior

I'm serving my internal js/css/lib in a different domain like https://staticfiles.example.com when my site is https://www.example.com
When using theme version before 8.9.0 I just set vendors to local and after generate files, copy js/css/lib folder to staticfiles folder, and in config.yaml file set like this:

vendors:
internal: local
plugins: local
js: https://staticfiles.example.com/js
css: https://staticfiles.example.com/css
images: https://staticfiles.example.com/images

Then my internal js/css/lib file will be serverd with staticfiles.example.com

But in theme version 8.9.0, js config has been removed and new custom cdn url added. I'm not using custom cdn but only another domain to server staticfile.

So will it be possible to add js config back and if people using custom cdn url, you can ignore this setting, but if using local for vendors, using js\css\images config to set domain and path.

@tyadan tyadan added the Bug Something isn't working label Jan 5, 2022
@welcome
Copy link

welcome bot commented Jan 5, 2022

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@ljcbaby ljcbaby linked a pull request Jan 9, 2022 that will close this issue
5 tasks
@ljcbaby ljcbaby mentioned this issue Jan 9, 2022
12 tasks
@stevenjoezhang stevenjoezhang added this to the 8.9.1 milestone Jan 24, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants