Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom CDN options #428

Merged
merged 7 commits into from
Dec 31, 2021
Merged

Custom CDN options #428

merged 7 commits into from
Dec 31, 2021

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Dec 30, 2021 •
edited
Loading

See #425

Known issues:

  • unavailable option is not working with other cdnjs mirrors
  • preconnect url is not updated
  • Need to publish minified version on npm
  • Rename variables
  • Unit test

@coveralls
Copy link

coveralls commented Dec 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1641533461

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%
Totals Coverage Status
Change from base Build 1638373727: 0.0%
Covered Lines: 138
Relevant Lines: 141
💛 - Coveralls

njzjz
njzjz reviewed Dec 31, 2021
View reviewed changes
scripts/helpers/engine.js Outdated Show resolved Hide resolved
@stevenjoezhang stevenjoezhang added this to the 8.9.0 milestone Dec 31, 2021
@stevenjoezhang stevenjoezhang linked an issue Dec 31, 2021 that may be closed by this pull request
[Feature] Add CDN for Chinese mainland #424
Closed
3 tasks
@stevenjoezhang stevenjoezhang merged commit 3dca98b into master Dec 31, 2021
@ljcbaby ljcbaby linked an issue Jan 9, 2022 that may be closed by this pull request
Vendors Problem with New 8.9.0 Custom CDN Feature #434
Closed
3 tasks
lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
@stevenjoezhang
Custom CDN options (next-theme#428)
7197f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz left review comments

Assignees
No one assigned
Labels
💥 Breaking Change Configurations
Projects
None yet
Milestone
8.9.0
Development

Successfully merging this pull request may close these issues.

Vendors Problem with New 8.9.0 Custom CDN Feature [Feature] Add CDN for Chinese mainland
3 participants
@stevenjoezhang @coveralls @njzjz