Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

升级到 v8.0.0-rc.5 发现的一些小问题 #75

Closed
3 tasks done
aoemon opened this issue Aug 3, 2020 · 7 comments · Fixed by #76
Closed
3 tasks done

升级到 v8.0.0-rc.5 发现的一些小问题 #75

aoemon opened this issue Aug 3, 2020 · 7 comments · Fixed by #76
Labels
Bug Something isn't working Question Solved
Milestone

Comments

@aoemon
Copy link

aoemon commented Aug 3, 2020

Please follow this Issue template to provide relevant information, such as source code repository, website URL and screenshots, which will help us investigate.
请按照此 Issue 模版提供相关信息,例如源码仓库、网站链接和屏幕截图,这将有助于我们进行调查。

Issue Checklist

  • I am using the latest version of NexT.
  • I have already read the relevant documents of Hexo and NexT.
  • I have already searched for current issues, which does not help me.

今天升级 next,从 v8.0.0-rc.3 升级到 v8.0.0-rc.5(或 v8.0.0-rc.4 )存在如下问题(以 Muse 为例):

  1. 文章标题下划线左右端无法对齐。

1

这在 v8.0.0-rc.3 中显示正常,可参考:v8.0.0-rc.3 测试

2

3

  1. 使用 fancybox 灯箱插件放大或缩小图片,滚动条消失或出现会导致页面抖动,但在 v8.0.0-rc.3 中显示正常。

v8.0.0-rc.3 测试

v8.0.0-rc.5 测试

  1. 移动端侧边栏展开并点击叉关闭后,汉堡包导航图标变为箭头导航图标(除非点击空白处才能变回汉堡包导航图标),与 PC 端不一致。

4

v8.0.0-rc.5 测试

这在 v8.0.0-rc.3 中显示正常:

5

v8.0.0-rc.3 测试

  1. Valine 评论系统,配置文件修改 meta 项参数值无效。

例如:

valine:
  ...
  meta: [nick, link]
  ...

这仍会在页面显示 “邮箱” 相关项。


我不太确定以上问题是否为预期行为?

@aoemon aoemon added the Question label Aug 3, 2020
@stevenjoezhang
Copy link
Member

stevenjoezhang commented Aug 3, 2020

谢谢反馈。

目前已知第 3 点是因为这一部分用 CSS 代替 JS 重写了,在移动端 hover 事件并不精确,因此表现与桌面端不同。见 https://developer.mozilla.org/en-US/docs/Web/CSS/@media/any-hover
theme-next/hexo-theme-next#459

第 4 点是由于 Hexo merge 配置文件的方式,导致 Valine 的 meta 选项无法被正确覆盖。可能需要把这个选项由数组改为字符串。
测试显示将配置文件中的 meta 设置为空数组时,Valine 会使用默认配置,因此可以绕过该问题。

@stevenjoezhang
Copy link
Member

FancyBox 打开时页面滚动条消失的行为是由 FancyBox 自身的样式控制的,而不是 NexT。仔细观察的话可以发现,在两个版本中,页面底部的 aplayer 歌词都会随着滚动条消失而产生跳动。我个人认为影响可以忽略。
NexT 近期对于 FancyBox 的改动只包括:在侧栏打开时,点击 FancyBox 图片后侧栏不再关闭。但这并不是问题的原因。

@aoemon
Copy link
Author

aoemon commented Aug 3, 2020

页面底部歌词确实也会产生跳动,但我最开始注意到的是整个页面的抖动,因为在 v8.0.0-rc.3 中页面是不会抖动的,不过确实问题不大😄。感觉 mediumzoom 也挺不错的,不会隐藏滚动条,而且无需引入 jquery。

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Aug 3, 2020

第一个问题已修复(#76),感谢 @799953468
Valine 的问题可以绕过,稍后更新。
侧边栏的箭头需要一些像素级的优化。另外发现了一个 theme-next/hexo-theme-next#952 引入的问题,左侧和右侧的汉堡包导航变为❌的动画是相同的,而不是镜像对称。

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Aug 3, 2020

Fixed in 6b9b175

这些问题应该都解决了,如果有其它疑问欢迎提出。这个 Issue 先关了。

在 meta 为空的情况下,Valine 似乎无法保存昵称、邮箱等信息。由于 Valine 自 1.14 版本起不再开源,NexT 团队无法 debug。有其他问题请联系 Valine 作者解决: https://github.com/xCss/Valine/issues

Reverted in 760fdc9

@stevenjoezhang
Copy link
Member

由于存在严重的隐私泄露、数据安全和开源的问题,NexT 已隐藏 Valine 的有关配置项,直到问题得到妥善解决。

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Question Solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants