Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sidebar position optional for all schemes #952

Merged
merged 7 commits into from
Jul 9, 2019
Merged

Make sidebar position optional for all schemes #952

merged 7 commits into from
Jul 9, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 7, 2019 •
edited
Loading

Breaking Change

sidebar:
-  # Sidebar Position, available values: left | right (only for Pisces | Gemini).
+  # Sidebar Position, available values: left | right.
  # Sidebar Position.
  position: left
  #position: right

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #164

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

  • Yes.
  • No.

https://github.com/theme-next/hexo-theme-next/pull/156/files#diff-90c3d2a8522cb0e6c0ac99af79e65607R9

@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 July 7, 2019 17:44
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@stevenjoezhang stevenjoezhang changed the title Fix setting sidebar position to left or right invalid in scheme Mist & Muse Allow setting sidebar position to left or right in scheme Muse & Mist Jul 7, 2019
@stevenjoezhang
Copy link
Contributor Author

Need to test if the bug in #164 still exists

@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@stevenjoezhang stevenjoezhang requested review from 1v9 and jiangtj July 7, 2019 22:49
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@theme-next theme-next deleted a comment Jul 7, 2019
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 8, 2019
@theme-next theme-next deleted a comment Jul 8, 2019
@theme-next theme-next deleted a comment Jul 8, 2019
@theme-next theme-next deleted a comment Jul 8, 2019
@stevenjoezhang
Copy link
Contributor Author

I suggest merging this PR first. For the issues it may cause, solve them in #951

@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@stevenjoezhang stevenjoezhang merged commit 9d71da8 into master Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the sidebar branch July 9, 2019 08:21
@1v9 1v9 changed the title Allow setting sidebar position to left or right in scheme Muse & Mist Make sidebar position available for all schemes Jul 9, 2019
@1v9 1v9 changed the title Make sidebar position available for all schemes Make sidebar position optional for all schemes Jul 9, 2019
@jiangtj
Copy link
Member

jiangtj commented Jul 10, 2019

image

O.O

@stevenjoezhang
Copy link
Contributor Author

@jiangtj already fixed in #951

@stevenjoezhang stevenjoezhang mentioned this pull request Aug 21, 2019
Closed
15 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Allow setting sidebar position to left or right in scheme Muse & Mist (…
98b81fb 
…theme-next#952)
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 3, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
💥 Breaking Change CSS 🎯 Roadmap
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @jiangtj @1v9