-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darkmode of DisqusJS #408
Conversation
Pull Request Test Coverage Report for Build 1520242562
💛 - Coveralls |
I personally recommend adapting the dark mode in the source code of DisqusJS itself, instead of NexT. This can benefit other developers and users who use disqusjs, even if they use other themes or frameworks. |
The native dark mode is mostly implemented in the color of the inherited theme, however SukkaW wraps all elements in order not to pollute. This Pull Request is an exact copy of SukkaW's blog, with the color names adjusted. |
It looks like skk doesn't want to build in a dark mode, otherwise it would have done that already. But I also agree that a dark mode should be built in or a basic template should be given for adaptation. |
@@ -0,0 +1,39 @@ | |||
if (hexo-config('disqusjs.enable') and hexo-config('darkmode')) { | |||
@media (prefers-color-scheme:dark) { | |||
html #dsqjs a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation seems incorrect here, should be 2 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
PR Checklist
PR Type
What is the current behavior?
Issue resolved: #141
What is the new behavior?