Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for null theme.open_graph.options (instead #460) #470

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

ljcbaby
Copy link
Member

@ljcbaby ljcbaby commented Feb 22, 2022

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • [] Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

@ljcbaby ljcbaby added this to the 8.10.1 milestone Feb 22, 2022
@ljcbaby ljcbaby requested a review from a team February 22, 2022 11:39
@ljcbaby ljcbaby self-assigned this Feb 22, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1881323190

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%

Totals Coverage Status
Change from base Build 1841800317: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls

@ljcbaby
Copy link
Member Author

ljcbaby commented Feb 24, 2022

Is the CLAbot offline?

@stevenjoezhang stevenjoezhang merged commit f4969a4 into master Feb 27, 2022
@stevenjoezhang stevenjoezhang deleted the instead-pr-460 branch February 27, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants