-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update microsoft-clarity.njk #480
Conversation
update the microsoft clarity inline script
Thanks so much for opening your first PR here! |
See also #451 |
Pull Request Test Coverage Report for Build 1937386099
💛 - Coveralls |
I see, but just a little diffenrent. It can't be minified.( It will cause a bug that clarity dashboard is empty... |
not about minified.js, just about inline script in output |
Oh, my bad, I didn't test this on an actual project. I thought minifying it would not change any behavior. I just did it like that to keep it consistent with the rest of the analytics providers. But I guess you need to use the exact code Microsoft provides @stevenjoezhang You can accept this PR. And sorry for the inconvenience |
Emm, the change is that the njk will use the exact code Microsoft provides. So could you give this pull request a milestone....? |
Is there anyone give the milestone to this pull? I don't have the permission...... |
It would be tagged when merged. |
Congrats on merging your first pull request here! 🎉 How awesome! |
update the microsoft clarity inline script
PR Checklist
PR Type
What is the current behavior?
Normal as we look like.
Issue resolved:
What is the new behavior?
Microsoft clarity works well.
How to use?
In NexT
_config.yml
: