Fix preconnect config for vendors with custom cdn #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
If we set
venders.custom_cdn_url: https://lib.baomitu.com/${cdnjs_name}/${version}/${cdnjs_file}
, thepreconnect
in head will be<link rel="preconnect" href="lib.baomitu.com" crossorigin="">
And in Safari, the console shows
Successfully preconnected to https://pinlyu.com/lib.baomitu.com
See: https://pinlyu.com
What is the new behavior?
If we set
venders.custom_cdn_url: https://lib.baomitu.com/${cdnjs_name}/${version}/${cdnjs_file}
, thepreconnect
in head will be<link rel="preconnect" href="https://lib.baomitu.com" crossorigin="">
And in Safari, the console will show
Successfully preconnected to https://lib.baomitu.com/
If we set
venders.custom_cdn_url: http://lib.baomitu.com/${cdnjs_name}/${version}/${cdnjs_file}
, thepreconnect
in head will be<link rel="preconnect" href="http://lib.baomitu.com" crossorigin="">
And in Safari, the console will show
Successfully preconnected to http://lib.baomitu.com/