Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify algolia logo if not enabled #514

Merged
merged 1 commit into from
May 21, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 3, 2022

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Algolia logo exists even if Algolia is not enabled. For example, https://theme-next.js.org/images/logo-algolia-nebula-blue-full.svg

What is the new behavior?

It's removed.

How to use?

In NexT _config.yml:

minify: true

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2266657502

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%

Totals Coverage Status
Change from base Build 2252331967: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls

@stevenjoezhang stevenjoezhang added this to the 8.11.2 milestone May 4, 2022
@stevenjoezhang stevenjoezhang merged commit 250a5c8 into next-theme:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants