Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN URL #61

Merged
merged 6 commits into from
Jul 26, 2020
Merged

Update CDN URL #61

merged 6 commits into from
Jul 26, 2020

Conversation

799953468
Copy link
Contributor

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

updated the comment

@welcome
Copy link

welcome bot commented Jul 26, 2020

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2020

CLA assistant check
All committers have signed the CLA.

mermaid:

# Internal version: 3.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to update the CDN version of animate_css. See the description in #41
Thanks!

@@ -858,16 +858,16 @@ vendors:
# Available values: local, jsdelivr, unpkg
internal: local

# Internal version: 3.1.0
Copy link
Member

@stevenjoezhang stevenjoezhang Jul 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal version means the version in source/lib: https://github.com/next-theme/hexo-theme-next/tree/master/source/lib
These files are not changed so it's not necessary to update the version.

See also #72

_config.yml Outdated
@@ -880,7 +880,7 @@ vendors:

# MathJax
# mathjax: //unpkg.com/mathjax@3/es5/tex-mml-chtml.js
# mathjax: //cdnjs.cloudflare.com/ajax/libs/mathjax/3.0.5/es5/tex-mml-chtml.js
# mathjax: //cdnjs.cloudflare.com/ajax/libs/mathjax/3.0.6/es5/tex-mml-chtml.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link returns 404:

curl -I https://cdnjs.cloudflare.com/ajax/libs/mathjax/3.0.6/es5/tex-mml-chtml.js
HTTP/2 404 
date: Sun, 26 Jul 2020 02:31:50 GMT
content-type: text/html; charset=utf-8
served-in-seconds: 0.001
cf-cache-status: HIT
age: 35
expires: Sun, 26 Jul 2020 06:31:50 GMT
cache-control: public, max-age=14400
cf-request-id: 042a8f67c7000092ec5dbfc200000001
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
strict-transport-security: max-age=15780000; includeSubDomains
server: cloudflare
cf-ray: 5b8ab4ec7d8f92ec-SJC
alt-svc: h3-27=":443"; ma=86400, h3-28=":443"; ma=86400, h3-29=":443"; ma=86400

The next release of MathJax would be 3.1.0 and including breaking changes. I will open another PR to fix it.

@799953468
Copy link
Contributor Author

@stevenjoezhang Sorry, it's my problem.

@stevenjoezhang
Copy link
Member

@799953468 That's all right. Thanks for your contribution!
There is no description about CDN in CONTRIBUTING.md, I will update it later.

@stevenjoezhang stevenjoezhang merged commit 1f26b10 into next-theme:master Jul 26, 2020
@welcome
Copy link

welcome bot commented Jul 26, 2020

Congrats on merging your first pull request here! 🎉 How awesome!

@stevenjoezhang stevenjoezhang mentioned this pull request Aug 1, 2020
12 tasks
lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants