-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Analytics only_pageview mode to GA4 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks so much for opening your first PR here! |
Pull Request Test Coverage Report for Build 4858498581
💛 - Coveralls |
Will be nice if we could get this change up to date and in. The old GA is going away soon. |
@maple3142 Can you change this Pull request to open? |
@stevenjoezhang Could you merge this pull request? Old GA is already deprecated. |
stevenjoezhang
approved these changes
Nov 29, 2023
Congrats on merging your first pull request here! 🎉 How awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
The custom pageview sending code (will be used when
only_pageview
is enabled) is using the old measurement protocol api.What is the new behavior?
Use the new GA4 measurement protocol api instead: https://developers.google.com/analytics/devguides/collection/protocol/ga4
How to use?
Create a new Google Analytics 4 resource, and get
api_secret
according to the instruction described here.In NexT
_config.yml
: