Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utterances/giscus with pjax #779

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

wangjiezhe
Copy link
Contributor

PR Checklist

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (formatting, linting).
  • Refactoring (no functional changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:

If we use utterances or giscus comment system with pjax enabled, and use 'og:title' to map blog post with issue or discussion, then the comment does not load correctly if we change to another page. The reason is that utterance/giscus will consult <meta property="og:title" content="***"> in the head, which is not reloaded by pjax. The the comment shown is actually comments for the last page.

What is the new behavior?

The meta tag for 'og:title' is reloaded by pjax, and comments are load correctly.

Copy link

welcome bot commented Mar 30, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang stevenjoezhang added this to the 8.20.0 milestone Mar 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8490689155

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.416%

Totals Coverage Status
Change from base Build 8434159810: 0.0%
Covered Lines: 394
Relevant Lines: 399

💛 - Coveralls

@stevenjoezhang stevenjoezhang merged commit 94dc7f1 into next-theme:master Mar 30, 2024
12 checks passed
Copy link

welcome bot commented Mar 30, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants