Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Algolia search: drop instantsearch.js #795

Merged
merged 10 commits into from
May 7, 2024
Merged

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented May 7, 2024

PR Checklist

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (formatting, linting).
  • Refactoring (no functional changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #794

TBD:

  • Debounce
  • Use <mark class="search-keyword"></mark>

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

Copy link

github-actions bot commented May 7, 2024

This pull request contains changes to the configuration file. Please make sure the documentation in NexT website is changed or added.
Please edit relevant source files here: https://github.com/next-theme/theme-next-docs/tree/master/source/docs and create a pull request with the changes here: https://github.com/next-theme/theme-next-docs/pulls

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8982344224

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.421%

Totals Coverage Status
Change from base Build 8909607057: 0.0%
Covered Lines: 395
Relevant Lines: 400

💛 - Coveralls

@stevenjoezhang stevenjoezhang added this to the 8.20.1 milestone May 7, 2024
@stevenjoezhang stevenjoezhang marked this pull request as ready for review May 7, 2024 08:41
@stevenjoezhang stevenjoezhang merged commit 1ca1077 into master May 7, 2024
16 of 17 checks passed
@stevenjoezhang stevenjoezhang deleted the algolia branch May 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants